Ensure feedback work for all trajectories #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hodgestar
reviewed
May 9, 2024
Co-authored-by: Eric Giguère <eric.giguere@calculquebec.ca>
hodgestar
reviewed
May 9, 2024
hodgestar
approved these changes
May 9, 2024
Ericgig
added a commit
to Ericgig/qutip
that referenced
this pull request
May 16, 2024
Ensure feedback work for all trajectories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the bug in collapse feedback that made it work properly only for the first trajectories. (#2422)
Also added a check in the feedback test to ensure the collapse argument is reset for each trajectories.