-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HEOM Parity support #2261
Open
gsuarezr
wants to merge
40
commits into
qutip:master
Choose a base branch
from
gsuarezr:parity
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
HEOM Parity support #2261
Changes from 29 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
1a2e5d0
Added FitBath and OhmicBath classes, fix spelling on solver_base
gsuarezr 27ed772
notebooks as example
gsuarezr 3ba219d
formatting
gsuarezr 40a914d
added tests
gsuarezr 3edecc0
Merge branch 'qutip:master' into master
gsuarezr f51033a
Make fit classes inherit, which broke tests, refactored functions and…
gsuarezr c880375
minor refactoring
gsuarezr 7080102
replaced tests to match new classes
gsuarezr 390c596
added parity support changed prints to __str__
gsuarezr fa563b5
deleted innecessary comments and code
gsuarezr c6a7d4e
Rewrote summary methods,added comments,eliminated unnecessary code
gsuarezr 5c03d92
Rewrote summary methods,added comments,eliminated unnecessary code
gsuarezr 5f0003c
moving parity to another branch
gsuarezr 22cdee6
Merge branch 'qutip:master' into parity
gsuarezr f16d52d
added parity support
gsuarezr fc794bc
Merge branch 'qutip:master' into parity
gsuarezr 26c49ed
moved example notebook to tutorials
gsuarezr 9699687
removed mpmath
gsuarezr 77f23a4
removed bosonic fitting tests
gsuarezr 2c74559
removed changes from other branches
gsuarezr b9d8093
codeclimate sugestions
gsuarezr 3fe627e
refactoring according to codeclimate
gsuarezr 65a8299
added changelog entry
gsuarezr ca7095a
revert unrelated changes
gsuarezr a79a305
revert unrelated changes 2
gsuarezr 5ee816a
revert unrelated changes 3
gsuarezr aaa45f1
revert unrelated changes 4
gsuarezr 27c878d
Merge branch 'qutip:master' into parity
gsuarezr 4172aef
Merge branch 'qutip:master' into parity
gsuarezr 4b5cfc1
make odd parity keyword only
gsuarezr e7f1360
Apply suggestions from code review
gsuarezr 87a23a0
Merge branch 'qutip:master' into parity
gsuarezr 01058af
added simple test
gsuarezr dd1f104
check broken tests
gsuarezr adaca75
daily
gsuarezr a5ce6cc
set use_mkl=False so tests pass for python 3.10
gsuarezr ce69039
code review suggestions
gsuarezr e004b44
Merge branch 'master' into parity
gsuarezr 07d1c38
missed import
gsuarezr 41ddaba
missed comma
gsuarezr File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
It adds odd parity support to HEOM's fermionic solver |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simon asked us to help distill and clarify this a little bit; how about:
" For fermionic baths only. Default is "False". "Parity" refers to the parity of the initial system state used with the HEOM. An example of an odd parity state is one made from applying an odd number of fermionic creation operators to a physical density operator. Physical systems have even parity, but allowing the generalization to odd-parity states allows one to calculate useful physical quantities like the system power spectrum or density of states. The form of the HEOM differs depending on the parity of the initial system state, so if this option is set to "True", a different RHS is constructed, which can then be used with a system state of odd parity. "