Add annotate cython files options when installing the module #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hodgestar
requested changes
Mar 22, 2023
setup.py
Outdated
| @@ -44,6 +44,13 @@ def process_options(): | |||
| options = _determine_user_arguments(options) | |||
| options = _determine_version(options) | |||
| options = _determine_compilation_options(options) | |||
| options["annotate"] = False | |||
There was a problem hiding this comment.
Could we move this into its own function named something like _determine_cythonize_options so that it's organized the same way as the other options?
hodgestar
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Looks good to me.
One last thought -- do we want to keep support for -a? The setup command already parses a bunch of options on its own while -a doesn't appear to clash with anything right now, it is easy for a single letter to clash (e.g. -b and -c are already used by the build subcommand).
|
I mostly use it as |
hodgestar
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add options to annotate the cython files at installation.
I used it when updating the stochastic solvers, but do not what to include it in that PR.