-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make non-collapsible titledpanes not highlight on mouseover #1517
base: main
Are you sure you want to change the base?
Conversation
In the process of adding the class to other titled panes, please don't merge yet :) |
Resolving other non-collapsible titled panes that appear clickable (but are not)
So edited a few more that appeared clickable when they shouldn't be (as they are not collapsible). |
That version of |
If I understand correctly, this PR is to make the top title change on hover but not the bottom one - because the top one can be expanded/collapsed, but the bottom one can't. Screen.Recording.2024-05-21.at.17.57.47.movtbh I'd never noticed this or seen it as problematic. If you think it needs a fix, then should it not go into public void makeNonCollapsible(TitledPane pane) {
pane.setCollapsible(false);
// Whatever other styling is needed here
} Hard-coding a reference to the CSS class feels a bit brittle to me, and is tied very much to QuPath in a way that is unusable elsewhere. And I imagine we'll end up with inconsistencies as we'll forget / extension writers won't know to add this style class... which to me seems potentially worse. You could also change Was there any particular user complaint or confusion caused by the default JavaFX approach of slightly changing the behavior on hover, regardless of the 'collapsible' status? |
Fair yeah, it's been bugging me, but I am happy to allow it to continue to bug me if it's not consequential or shared by others
It certainly helps for collapsible panes |
No description provided.