Fix async_call.asyncio() and ConstFuture #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug where async_call.asyncio() returned futures.ConstFuture.
|
|
||
| """ | ||
| if is_pure_async_fn(fn): | ||
| return await fn.asyncio(*args, **kwargs) |
There was a problem hiding this comment.
Are you sure this is correct?
>>> @asynq.asynq(pure=True)
... def f():
... pass
...
>>> asynq.is_pure_async_fn(f)
True
>>> f.asyncio
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: 'PureAsyncDecoratorPythonWrapper' object has no attribute 'asyncio'
There was a problem hiding this comment.
Python 3.11.6 (main, Nov 14 2023, 09:36:21) [GCC 13.2.1 20230801] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>
>>>
>>> import asynq
>>> @asynq.asynq(pure=True)
... def f():
... pass
...
>>> asynq.is_pure_async_fn(f)
True
>>>
>>> f.asyncio
<bound method PureAsyncDecorator.asyncio of @asynq(pure=True) __main__.f>
>>>
>>> print(type(f))
<class 'qcore.decorators.decorate.<locals>.PythonWrapper'>
print(f.asyncio)
<bound method PureAsyncDecorator.asyncio of @asynq(pure=True) __main__.f>qcore==1.10.0
There was a problem hiding this comment.
Maybe try rm -rf __pycache__?
There was a problem hiding this comment.
Thanks, I may have had an old qcore or something.
dkang-quora
commented
Dec 3, 2023
| d = yield async_call.asynq(f, *args, **kwargs) | ||
| return d | ||
|
|
||
| for f in [f1, f2, f3]: |
There was a problem hiding this comment.
f2(pure=True) should cover your case
JelleZijlstra
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where
async_call.asyncio()returnedfutures.ConstFuture.