Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests #51

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Add unit tests #51

wants to merge 28 commits into from

Conversation

EdgarScott
Copy link

Hi. I've analysed your codebase and noticed that it is not fully tested.
I've written some tests for the methods in the following classes with the help of Diffblue Cover:

  • qunar.tc.bistoury.clientside.common.meta.Numbers
  • qunar.tc.decompiler.code.Instruction
  • qunar.tc.decompiler.code.SwitchInstruction
  • qunar.tc.decompiler.main.extern.IIdentifierRenamer_Type
  • qunar.tc.decompiler.modules.renamer.ConverterHelper
  • qunar.tc.decompiler.struct.attr.StructAnnDefaultAttribute
  • qunar.tc.decompiler.struct.attr.StructAnnotationAttribute
  • qunar.tc.decompiler.struct.attr.StructAnnotationParameterAttribute
  • qunar.tc.decompiler.struct.attr.StructBootstrapMethodsAttribute
  • qunar.tc.decompiler.struct.attr.StructConstantValueAttribute
  • qunar.tc.decompiler.struct.attr.StructEnclosingMethodAttribute
  • qunar.tc.decompiler.struct.attr.StructExceptionsAttribute
  • qunar.tc.decompiler.struct.attr.StructGeneralAttribute
  • qunar.tc.decompiler.struct.attr.StructGenericSignatureAttribute
  • qunar.tc.decompiler.struct.attr.StructInnerClassesAttribute
  • qunar.tc.decompiler.struct.attr.StructLineNumberTableAttribute
  • qunar.tc.decompiler.struct.attr.StructMethodParametersAttribute
  • qunar.tc.decompiler.struct.gen.VarType
  • qunar.tc.decompiler.struct.gen.generics.GenericType
  • qunar.tc.decompiler.util.InterpreterUtil
  • qunar.tc.bistoury.instrument.client.spring.el.CodeFlow
  • qunar.tc.bistoury.instrument.client.spring.el.CollectionUtils
  • qunar.tc.bistoury.instrument.client.spring.el.NestedExceptionUtils
  • qunar.tc.bistoury.instrument.client.spring.el.ObjectUtils
  • qunar.tc.bistoury.instrument.client.spring.el.Operator_DescriptorComparison
  • qunar.tc.bistoury.instrument.client.spring.el.StringUtils
  • qunar.tc.bistoury.serverside.agile.Base64
  • qunar.tc.bistoury.serverside.agile.Strings

Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other classes that you consider important in a subsequent PR.

@JohnLBergqvist
Add Unit Tests for qunar.tc.bistoury.clientside.common.meta.Numbers
83680f4 
These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.code.Instruction
d415a74 
These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.code.SwitchInstruction
c7a8de2 
These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.main.extern.IIdentifierRenamer…
b28acc5 
…_Type

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.modules.renamer.ConverterHelper
321d4ec 
These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.struct.attr.StructAnnDefaultAt…
54a1b0c 
…tribute

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.struct.attr.StructAnnotationAt…
2f4050a 
…tribute

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.struct.attr.StructAnnotationPa…
baf847e 
…rameterAttribute

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.struct.attr.StructBootstrapMet…
3c9c9ed 
…hodsAttribute

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.struct.attr.StructConstantValu…
7d8805c 
…eAttribute

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.struct.attr.StructEnclosingMet…
45297e3 
…hodAttribute

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.struct.attr.StructExceptionsAt…
6cc3d84 
…tribute

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.struct.attr.StructGeneralAttri…
0a9667b 
…bute

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.struct.attr.StructGenericSigna…
0f52882 
…tureAttribute

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.struct.attr.StructInnerClasses…
2325717 
…Attribute

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.struct.attr.StructLineNumberTa…
be245a8 
…bleAttribute

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.struct.attr.StructMethodParame…
e1ba0be 
…tersAttribute

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.struct.gen.VarType
aa65044 
These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.struct.gen.generics.GenericType
3b90313 
These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.decompiler.util.InterpreterUtil
bf8b3cb 
These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.bistoury.instrument.client.spring.el.Code…
3c0ed14 
…Flow

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.bistoury.instrument.client.spring.el.Coll…
929d0e5 
…ectionUtils

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.bistoury.instrument.client.spring.el.Nest…
19acbdf 
…edExceptionUtils

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.bistoury.instrument.client.spring.el.Obje…
5112ae5 
…ctUtils

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.bistoury.instrument.client.spring.el.Oper…
bdbf2f8 
…ator_DescriptorComparison

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.bistoury.instrument.client.spring.el.Stri…
9bdd2bc 
…ngUtils

These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.bistoury.serverside.agile.Base64
2c662ec 
These tests were written using Diffblue Cover
@JohnLBergqvist
Add Unit Tests for qunar.tc.bistoury.serverside.agile.Strings
58801ab 
These tests were written using Diffblue Cover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EdgarScott @JohnLBergqvist