Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lazy loading on scroll #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

LidoDev
Copy link

@LidoDev LidoDev commented Oct 1, 2019

Lazy loading is missing on scroll event. The list mentions may be opened top when container bottom is not visible, i think it will be pretty to add an option for overriding this behavior to let client configuring the view to be opening to bottom or top. i will create a pull request on this.
#101

@MadSpindel
Copy link
Member

We have a defaultMenuOrientation. Could we use that one to get the result that you want? I believe you are asking for something like "forceTop" or "forceBottom"?

@LidoDev
Copy link
Author

LidoDev commented Oct 27, 2019

Yes, but the current behavior is that when bottom is not visible we override defaultMenuOrientation. Yes we can use it with forceBttom or forceTop or we change the type to json
defaultMenuOrientation:{
orienation : ennum ['bottom', 'top'],
force: boolean
}.

In the same commit there is the lazy loading on scroll event.

@sidharthancr
Copy link

Please add this in. Badly needing this feature @MadSpindel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants