Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http3: rename ListenAndServe to ListenAndServeTLS #4522

Merged

Conversation

ETZhangSX
Copy link
Contributor

Close #4521

Copy link

google-cla bot commented May 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.17%. Comparing base (056a332) to head (32c9b30).
Report is 1 commits behind head on master.

❗ Current head 32c9b30 differs from pull request most recent head 50f7a04. Consider uploading reports for the commit 50f7a04 to get more accurate results

Files Patch % Lines
http3/server.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4522      +/-   ##
==========================================
+ Coverage   85.16%   85.17%   +0.01%     
==========================================
  Files         154      154              
  Lines       14782    14804      +22     
==========================================
+ Hits        12588    12608      +20     
- Misses       1687     1689       +2     
  Partials      507      507              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann merged commit f3cecf9 into quic-go:master May 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The method ListenAndServe in package http3 is not compatible with http
2 participants