Properly forward missing pinentry errors #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before running the following command without pinentry in PATH resulted in: Login failed: Could not sync vault: decrypt: MAC mismatch With this change the error is properly forwarded and displayed $ ./goldwarden vault login --email me@example.com Login failed: exec: "pinentry": executable file not found in $PATH
|
Again, thanks for the PR! |
Interesting. Not sure why it then ran into a MAC mismatch, maybe the crypto key was nil and it still went on to the code path decrypting the vault? |
|
nil or empty string but that's what I suspect, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before running the following command without pinentry in PATH resulted in:
Login failed: Could not sync vault: decrypt: MAC mismatchWith this change the error is properly forwarded and displayed