Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing several buffer overflow in parse_arguments in n64split #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sn0wfreezeDev
Copy link

Hi,

for a university project we had look for buffer overflows in open source projects.
We have tested your software and discovered several buffer overflows in the n64split tool.

We have fixed those in this commit using strncpy instead of strcpy.

To reproduce the buffer overflow compile n64split with the gcc flag -fno-stack-protector and run it with the following input:
./n64split $(python -c "print ''.join(c * 4096 for c in 'ABC') + 'D' * 72")

This will create a segmentation fault, because it will overwrite among others the return address of the main function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant