Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To clarify, the loophole was that although the user could properly create instances of
LoxList
by using bracket notation for a list literal in the REPL, they could also explicitly create an instance ofList
. This would result in an object in a hybrid state, without anelements
property and no way to modify it to behave like an actual list. In this PR, we introduced theinstanceType
property forLoxClass
so that when instances of it are created viaLoxClass.call()
, we create aLoxList
instance if the class' name isList
, andLoxInstance
instance otherwise. This is what closes the loophole. (It should be noted that the name gets set toList
when the interpreter is first instantiated and processes the class declaration forList
in the standard library.)We also included the following changes:
makeList()
inInterpreter
to get rid of code duplication but also made it public so that it could be used in unit testsLoxValue
, which is used only for unit testing, for clarity