Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "brand" fonts in title #1

Closed
raae opened this issue Mar 26, 2024 · 7 comments · Fixed by #4
Closed

Use "brand" fonts in title #1

raae opened this issue Mar 26, 2024 · 7 comments · Fixed by #4

Comments

@raae
Copy link
Member

raae commented Mar 26, 2024

  • Use the boldest var(--neo-Grotesque) for DATA and primary color for DATA
  • Use apricot for the "in the wild"
  • Set the title to "Data in the wild" and style the h1 span to apricot

Data in the Wild - new design

@raae raae changed the title Use "brand" fonts Use "brand" fonts in title Mar 26, 2024
@raae
Copy link
Member Author

raae commented Mar 28, 2024

Apricot font files: Archive.zip

@rishi-raj-jain
Copy link
Contributor

Damn!

6a08562 got directly committed 😅

I'll make sure to create PRs in the future.

But it does all of what was listed in the tasks.

Please take a look?

@rishi-raj-jain
Copy link
Contributor

The commit does the following apart from what was asked in the tasks:

@rishi-raj-jain
Copy link
Contributor

Ah it reflected on https://datainthewild.fm/ superbly 👇🏻

Screenshot 2024-03-28 at 5 43 25 PM

@raae
Copy link
Member Author

raae commented Mar 28, 2024

I'd rather not do utility classes in this project (mainly to see how it feels). So, if you could change it to be defined in the global CSS as "h1 span" for apricot and em for the brand color, that would be great.

What do you mean Inter was not loaded, using the Modern Font Stacks https://github.com/system-fonts/modern-font-stacks#neo-grotesque, so it should use one of the fonts in th e?

@raae
Copy link
Member Author

raae commented Mar 28, 2024

My bad with the instruction on the title should have been <em>Data</em> <span>in the wild</span>

@rishi-raj-jain
Copy link
Contributor

@raae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants