Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize images #3

Closed
raae opened this issue Mar 28, 2024 · 3 comments · Fixed by #5
Closed

Optimize images #3

raae opened this issue Mar 28, 2024 · 3 comments · Fixed by #5

Comments

@raae
Copy link
Member

raae commented Mar 28, 2024

In component "Reel":

  • Use Astro image or other methods so the images are not 1 MB each.
  • Make sure the images are still responsive as they are now.
  • Add background color of var(--paper) so the border does not show through while loading

Background images:

@rishi-raj-jain
Copy link
Contributor

Let's get to this with #1 done?

@raae
Copy link
Member Author

raae commented Mar 28, 2024

You can start on it in a separate PR.

@rishi-raj-jain
Copy link
Contributor

Could this approach be user https://docs.astro.build/en/guides/images/#generating-images-with-getimage, but in the style section instead of in an inline stye?

Yup.

@raae raae closed this as completed in #5 Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants