Improvement of the Presto Example : #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you have any questions on my PR, feel free |
msumit
reviewed
May 14, 2019
fix: dev: SDK-364: Oracle Multi AD changes required in qds-sdk
- Simplified a lot the whole script - Made everything compatible with Python 3 - Removed the print() for proper logger - Added assert() for parameters sanity checks - Allows passing keywords arguments to pd.read_csv() ...
Help for the bug of the missing column names
|
Hey guys,
Now, even if Qubole query got stuck, the function still return with error. |
|
Also, it seems that Travis CI is failing to install Python 3.3 and 2.6 (??) but I don't think it's related to this PR |
|
yes @JeanLescut looks like the Ubuntu version was not pinned in our configuration and hence it got updated to 16.XX in which these python versions are not present, will fix it. Thanks for the PR btw |
|
@JeanLescut I have fixed the issue, please rebase your branch once more and squash all your commits. |
chattarajoy
force-pushed
the
unreleased
branch
2 times, most recently
from
8a95947
to
caec9b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...