clair: orderly shutdown #2015
Open
clair: orderly shutdown #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This changes the incorrect-but-at-least-stops implementation with a little tree of goroutines. The full fix requires `context.WithoutCancel`, which we can't quite use yet. Closes: quay#1946 Signed-off-by: Hank Donnay <hdonnay@redhat.com>
This means that the request contexts should now only be able to be cancelled via the `(http.Server).Shutdown`/`(http.Server).Close` methods. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
hdonnay
force-pushed
the
bug/shutdown-1_22
branch
from
18508aa
to
66931f1
Compare
|
Not sure if there's a good way to cook up a test for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1946