Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(valuebox): Override theme color when default only #9460

Merged
merged 3 commits into from May 7, 2024

Conversation

gadenbuie
Copy link
Collaborator

For #9453

Description

Previously if a $valuebox-bg-{color} were overriden for a given bootswatch theme, e.g. "flatly", the theme override would also replace a user definition of $valuebox-bg-{color}.

See #9453 (comment) for complete details.

This doesn't completely resolve #9453 in the sense that there the user set $danger and expected value boxes with bg-danger to follow. After this PR, the recommendation for customizing value box background colors would be to directly set $valuebox-bg-danger.

For example

// instead of this
/*-- scss:defaults --*/
$danger: #009e73 !default;

// do this
/*-- scss:defaults --*/
$danger: #009e73 !default;
$valuebox-bg-danger: $danger !default;

Checklist

I have (if applicable):

  • filed a contributor agreement.
  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog
    • I'll add an item to changelog-1.5.md; can you provide guidance as to what heading to use or where to put the item?

Previously if a `$valuebox-bg-{color}` were overriden for a given bootswatch theme, e.g. "flatly", users could not set `$valuebox-bg-{color}`.
@cscheid
Copy link
Collaborator

cscheid commented May 6, 2024

Hi @gadenbuie sorry for the delay.

  • I'll add an item to changelog-1.5.md; can you provide guidance as to what heading to use or where to put the item?

## Other Fixes and Improvements seems the best.

@cscheid cscheid merged commit c2fe9e1 into main May 7, 2024
6 checks passed
@cscheid cscheid deleted the fix/value-box-override-default branch May 7, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarto dashboard value boxes doesn't adhere to theme changes
2 participants