Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3 xml fix #8392

Open
wants to merge 2 commits into
base: v1.3
Choose a base branch
from
Open

1.3 xml fix #8392

wants to merge 2 commits into from

Conversation

edwintorok
Copy link
Contributor

Description

Word was not able to open DOCX with nested tables due to the XML not conforming to its schema.

I used docx-validator and OOXMLValidatorCLI:

  • tags need to be in the order defined in wml.xsd
  • some tags were missing (e.g. tblGrid is required)
  • OOXMLValidatorCLI complained about using start/end in a Transitional (as opposed to strict) schema. Pandoc only supports transitional schema.

To fix nested tables apparently an empty paragraph needs to be inserted.

Tested by @vtraag (OP) and myself (using Office.com).

This doesn't mean that Quarto's output will now always pass the DOCX validator, but other problems can be fixed as they are found.

Checklist

I have (if applicable):

  • filed a contributor agreement.
  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog

(I couldn't find a separate changelog. I have written some commit messages though)

I used docx-validator and OOXMLValidatorCLI:
* tags need to be in the order defined in wml.xsd
* some tags were missing (e.g. tblGrid is required)
* OOXMLValidatorCLI complained about using start/end in a Transitional
  (as opposed to strict) schema. Pandoc only supports transitional
  schema.

Signed-off-by: Edwin Török <edwin@etorok.net>
Apparently an empty paragraph is needed.

Fixes quarto-dev#6357

Signed-off-by: Edwin Török <edwin@etorok.net>
@edwintorok
Copy link
Contributor Author

I haven't yet tried to implement the equivalent fix on 1.4 or main (1.3 had fewer validation errors than 1.4 so I did that first)

@cscheid
Copy link
Collaborator

cscheid commented Jan 23, 2024

Thanks for all your messages and work on validation, but we're not working on 1.3 anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants