Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft to support unexpected enum values #700

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brice-laurencin
Copy link

resolves #692

This is a first draft, I would follow the guidelines if you thinks this feature is useful.
I still have an issue with numbered enum that I need to dig into, but I'd like to have a first feedback on this version.

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket

Copy link
Contributor

🎊 PR Preview 9e15497 has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-700.surge.sh

Copy link
Collaborator

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @brice-laurencin Thank you for your pull request!

Would be great to have a documentation for our users, to know how to use the new property, WYT?

@brice-laurencin
Copy link
Author

Definitely.
This is a first draft to know if I should push the effort further, if you (the maintainers of the extension) think this is valuable.

@ricardozanini
Copy link
Member

@brice-laurencin please go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support unexpected values in Enums
3 participants