Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analysis library for Rizin v0.5.x #457

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

sidra-asa
Copy link
Collaborator

@sidra-asa sidra-asa commented Jan 17, 2023

Description

Close #334.
This PR is based on #335 .
It aims to updates the Rizin-based analysis library to work with the current Rizin at the dev branch.
The current release is v0.5.x.
It includes the following changes -

  • Update parser for command axtj
  • Replace command axffj with pdfj and is.j since Rizin v0.4.x removed it.
  • Rewrite _get_method_by_address by using is.j to precisely find the method via a given address.
  • Add support to parse methods with variable-length arguments.
  • Refactor to use the same code to parse the output of isj and is.j.

Code Changes

  • quark/core/rzapkinfo.py
  • quark/utils/tools.py

Test Plans

All tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023

Codecov Report

Patch coverage: 89.28% and project coverage change: +0.09 🎉

Comparison is base (b3a249b) 79.19% compared to head (ee28adb) 79.29%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
+ Coverage   79.19%   79.29%   +0.09%     
==========================================
  Files          63       64       +1     
  Lines        4960     5008      +48     
==========================================
+ Hits         3928     3971      +43     
- Misses       1032     1037       +5     
Flag Coverage Δ
unittests 79.29% <89.28%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
quark/core/rzapkinfo.py 78.67% <86.11%> (-0.24%) ⬇️
quark/utils/tools.py 75.86% <100.00%> (ø)
tests/core/test_apkinfo.py 96.75% <100.00%> (+0.51%) ⬆️
tests/core/test_rzapkinfo.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@haeter525 haeter525 self-assigned this Jan 17, 2023
@haeter525 haeter525 linked an issue Jan 18, 2023 that may be closed by this pull request
@sidra-asa sidra-asa changed the title Update analysis library for Rizin v0.5.x Update analysis library for Rizin v0.6.2 Oct 9, 2023
@sidra-asa sidra-asa changed the title Update analysis library for Rizin v0.6.2 Update analysis library for Rizin v0.5.x Oct 9, 2023
@sidra-asa
Copy link
Collaborator Author

Since the release version of Rizin is v0.6.2.
I will close this PR, and create another one for the core library upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update analysis library for Rizin v0.5 Update analysis library for Rizin v0.4.x
3 participants