Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quark Script APIs to support comparison of register values #378

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

haeter525
Copy link
Member

@haeter525 haeter525 commented Aug 19, 2022

Description

Please refer to #324.

This PR adds the following three Quark script APIs to support comparison of register values.

  1. getPackageName(samplePath)
  2. getLength(argument)
  3. methodInstance.compareValueOf(valueA, valueB)

Test Plans

  • All tests passed

@pep8speaks
Copy link

pep8speaks commented Aug 19, 2022

Hello @haeter525! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 205:42: E203 whitespace before ':'

Line 2:80: E501 line too long (82 > 79 characters)

Line 2:80: E501 line too long (82 > 79 characters)

Line 2:80: E501 line too long (82 > 79 characters)

Comment last updated at 2022-08-19 20:10:42 UTC

@haeter525 haeter525 force-pushed the feat/quark_script_for_detecting_register_value_comparison branch from 1445a90 to c2da833 Compare August 19, 2022 16:01
@codecov-commenter
Copy link

Codecov Report

Base: 76.03% // Head: 76.89% // Increases project coverage by +0.85% 🎉

Coverage data is based on head (53787d7) compared to base (2ce703f).
Patch coverage: 93.22% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
+ Coverage   76.03%   76.89%   +0.85%     
==========================================
  Files          56       59       +3     
  Lines        4261     4480     +219     
==========================================
+ Hits         3240     3445     +205     
- Misses       1021     1035      +14     
Flag Coverage Δ
unittests 76.89% <93.22%> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
quark/core/struct/registerobject.py 91.48% <50.00%> (ø)
quark/core/interface/baseapkinfo.py 78.65% <70.00%> (-1.35%) ⬇️
quark/script/utils.py 75.00% <75.00%> (ø)
quark/script/__init__.py 91.77% <85.00%> (-2.30%) ⬇️
quark/core/rzapkinfo.py 77.53% <90.00%> (+1.80%) ⬆️
quark/core/apkinfo.py 91.15% <100.00%> (+0.71%) ⬆️
quark/core/quark.py 74.06% <100.00%> (+1.50%) ⬆️
quark/evaluator/pyeval.py 92.00% <100.00%> (+0.89%) ⬆️
tests/core/test_apkinfo.py 96.06% <100.00%> (+0.44%) ⬆️
tests/evaluator/test_pyeval.py 98.12% <100.00%> (+0.12%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants