Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simulator selector. #82

Merged
merged 5 commits into from Apr 23, 2020
Merged

Add simulator selector. #82

merged 5 commits into from Apr 23, 2020

Conversation

sergeisakov
Copy link
Collaborator

No description provided.

@95-martin-orion
Copy link
Collaborator

From the Bazel failure, I suspect simmux.h needs to be added to the qsim_lib BUILD rule.

@95-martin-orion
Copy link
Collaborator

The Docker test failure can be ignored for now - there was a breaking change in google-api-python-client that should be fixed in the next release. (Not clear how long until that release, though)

@MichaelBroughton
Copy link
Collaborator

You can pin the version to 1.8.0 in your requirements files to fix this pretty easily. Should we just do that ?

@95-martin-orion
Copy link
Collaborator

You can pin the version to 1.8.0 in your requirements files to fix this pretty easily. Should we just do that ?

I agree with this solution - it would be more stable in the long run to have a pinned version and update manually.

@busunkim96
Copy link

Hi! Dropping by since I saw you referenced googleapis/google-api-python-client#876.

google-api-python-client 1.8.2 has been released and removes the problematic googleapiclient.__version__ line. In addition, if you have any references to apiclient we recommend you replace them with googleapiclient instead.

@sergeisakov sergeisakov merged commit 9708283 into master Apr 23, 2020
@sergeisakov sergeisakov deleted the simmux branch April 23, 2020 12:17
@sergeisakov sergeisakov linked an issue Apr 29, 2020 that may be closed by this pull request
@95-martin-orion 95-martin-orion mentioned this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate simulator selection
4 participants