Make FH fetch_publication_data more stable
#171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
reviewed
Nov 17, 2022
|
|
||
| # Determine file IDs. Note these are not permanent on Dryad. | ||
| file_ids = {} | ||
| for line in urlopen("https://doi.org/10.5061/dryad.crjdfn32v").readlines(): |
There was a problem hiding this comment.
is this parsing the human-readable html website? If so, this seems just as unstable. What if they add a newline between the filename.zip and the id?
There was a problem hiding this comment.
Yes this would break it. It might be that this is more stable than the file IDs - the file IDs changed at least once since fetch_publication_data was added, but I don't think the html has. I think the only way to hermetically seal it is to tell Dryad to give individual files DOIs, or use a different service that does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165.
As documented there, individual file IDs are not permanent on Dryad. The strategy here is to determine these from the (permanent) DOI.
Could be a cleaner way to do this, comments welcome.