Create a Subtract bloq #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the relative -> absolute is the correct fix for this particular issue |
|
Can you take a look at #933, revert the imports change, and resolve conflicts? |
|
@mpharrigan done, ptal |
fdmalone
reviewed
May 15, 2024
| @@ -409,7 +409,7 @@ class SimpleAddConstant(Bloq): | |||
| [Improved quantum circuits for elliptic curve discrete logarithms](https://arxiv.org/abs/2001.09580) Fig 2a | |||
| """ | |||
|
|
|||
| bitsize: int | |||
| bitsize: Union[int, sympy.Expr] | |||
There was a problem hiding this comment.
We have a SymbolicInt in qualtran.symbolics.types now.
fdmalone
reviewed
May 15, 2024
| Args: | ||
| a_dtype: Quantum datatype used to represent the integer a. | ||
| b_dtype: Quantum datatype used to represent the integer b. Must be large | ||
| enough to hold the result in the output register of a + b, or else it simply |
fdmalone
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #235 since to do comparison in N Toffolis we need to be able to do subtraction