-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added optional params sub_bit_prec
and epsilon
to preprocess_lcu_coefficients_for_reversible_sampling
#861
Added optional params sub_bit_prec
and epsilon
to preprocess_lcu_coefficients_for_reversible_sampling
#861
Conversation
…ficients_for_reversible_sampling
@tanujkhattar it seems that there is a problem with Pylint, if I run it locally it always gives errors for the same files (which have not been modified):
Is this normal or I'm doing something wrong? |
Are you running ./check/pylint? |
You might need to reinstall the requirements,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just spell out the kwargs though.
@Vicara12 Can you please address the comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've addressed the comments and made some more minor improvements which will be useful in a followup PR I'm working on. We can merge this.
I've addressed all the comments so we can merge now.
This PR solves issue #799. Now$\epsilon = 2^{-n_b}$ .
preprocess_lcu_coefficients_for_reversible_sampling
accepts either a toleranceepsilon
or a number of bits of precisionsub_bit_prec
, related as