Introduce types to t_complexity
#835
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
changed the title
t_complexity
mpharrigan
force-pushed
the
2024-03/typed-t-complexity
branch
from
3839e7c
to
0f6d91f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything is a bloq now, so we can indicate that with types in the
t_complexityfunction. It will now duck-type for bloqs. There are some tests that still want to find the t complexity of things that contain bloqs, so I added a_compatversion. I moved all the places where you literally need to get the TComplexity to a gate to explicit calls to_from_directly_countable(now with a_cirqsuffix) so its more explicit where these values are coming from.Depends on #825