Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set maxsize of request queue to Quantum Engine #6576

Merged
merged 3 commits into from Apr 30, 2024

Conversation

senecameeks
Copy link
Collaborator

@senecameeks senecameeks commented Apr 25, 2024

We want to prevent overwhelming the engine tasks with too many requests.

Setting a maxsize does not reject requests that happen after the queue is full. Instead, when a request is to be put into the queue it will wait until a free slot is available before adding.

We also limit the size of the request messages sent to prevent overloading the server with very large requests.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.79%. Comparing base (2474d47) to head (fc4c293).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6576   +/-   ##
=======================================
  Coverage   97.79%   97.79%           
=======================================
  Files        1124     1124           
  Lines       95658    95659    +1     
=======================================
+ Hits        93549    93550    +1     
  Misses       2109     2109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@senecameeks senecameeks marked this pull request as ready for review April 30, 2024 17:00
@senecameeks senecameeks merged commit 614c78a into quantumlib:main Apr 30, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants