Equivalent Measurements with equivalent invert masks should evaluate … #6339
+30
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishitkshah
requested review from
wcourtney,
vtomole,
cduck,
verult and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6339 +/- ##
==========================================
- Coverage 97.81% 97.80% -0.01%
==========================================
Files 1111 1111
Lines 97054 97068 +14
==========================================
+ Hits 94931 94937 +6
- Misses 2123 2131 +8 ☔ View full report in Codecov by Sentry. |
NoureldinYosri
requested changes
Jan 2, 2024
|
|
||
| def right_trim_mask(invert_mask): | ||
| if invert_mask is None or len(invert_mask) == 0: | ||
| return invert_mask |
There was a problem hiding this comment.
this assumes that invert_mask can be None which it's not
| @@ -91,6 +91,19 @@ def __init__( | |||
| self._invert_mask = invert_mask or () | |||
| if self.invert_mask is not None and len(self.invert_mask) > self.num_qubits(): | |||
| raise ValueError('len(invert_mask) > num_qubits') | |||
|
|
|||
| def right_trim_mask(invert_mask): | |||
There was a problem hiding this comment.
add type hint
def right_trim_mask(invert_mask: Tuple[bool, ...]) -> Tuple[bool, ...]:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…equal
Fix for the issue #6093 (equivalent measurements evaluate as unequal)