Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable placement notebook test. #5646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −2
Open

Enable placement notebook test. #5646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions dev_tools/notebooks/isolated_notebook_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@
# Please, always indicate in comments the feature used for easier bookkeeping.

NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES: List[str] = [
# Hardcoded qubit placement
'docs/google/qubit-placement.ipynb',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually "Enable" the test? Note that "**/google/*.ipynb" is part of SKIP_NOTEBOOKS below, so my understanding was that all google/* notebooks are not tested by default.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, it doesn't seem to launch it off, but might still be worth removing since hardcoded placement is now public. WDYT ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this enables the checks for "--pre".

Should we also delete "pip install --pre" in that notebook?

# get_qcs_objects_for_notebook
'docs/noise/calibration_api.ipynb',
'docs/tutorials/google/colab.ipynb',
Expand Down