ZKR-1371-Update-Abstract-Interpretation-Code (#23)

* ZKR-1371-Update-Abstract-Interpretation-Code * Re-add TODO --------- Co-authored-by: Jan Gorzny <j.gorzny@gmail.com>
quantstamp · Aug 24, 2023 · 001adfd · 001adfd
1 parent 25b85d1
commit 001adfd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/korrekt/src/circuit_analyzer/analyzer.rs b/korrekt/src/circuit_analyzer/analyzer.rs
@@ -167,8 +167,6 @@ impl<'b, F: Field> Analyzer<F> {
                                 let advices = abstract_expr::extract_columns(poly);
                                 let eval = abstract_expr::eval_abstract(poly, &selectors);
 
-                                column.index();
-
                                 if eval != AbsResult::Zero && advices.contains(&(column, rotation))
                                 {
                                     used = true;

diff --git a/korrekt/src/circuit_analyzer/layouter.rs b/korrekt/src/circuit_analyzer/layouter.rs
@@ -83,7 +83,8 @@ impl<'a, F: Field> Layouter<F> for &'a mut AnalyticLayouter<F> {
 
         self.eq_table.insert(left, right);
         Ok(())
-        //todo!("handle instance columns") ticket created: https://quantstamp.atlassian.net/browse/ZKR-1238
+
+        //todo!("handle instance columns"); Quantstamp ticket ZKR-1881
     }
 
     fn get_root(&mut self) -> &mut Self::Root {
@@ -95,10 +96,10 @@ impl<'a, F: Field> Layouter<F> for &'a mut AnalyticLayouter<F> {
         NR: Into<String>,
         N: FnOnce() -> NR,
     {
-        //todo!("handle namespaces");ticket created: https://quantstamp.atlassian.net/browse/ZKR-1238
+        // implementation not needed at this time
     }
 
     fn pop_namespace(&mut self, _gadget_name: Option<String>) {
-        //todo!("handle namespaces");ticket created: https://quantstamp.atlassian.net/browse/ZKR-1238
+        // implementation not needed at this time
     }
 }