Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FloatingContextMenu should not overflow on the right, when possible #1344

Closed
wants to merge 1 commit into from

Conversation

AyushAgrawal-A2
Copy link
Contributor

@AyushAgrawal-A2 AyushAgrawal-A2 commented May 11, 2024

closes #1343

Changes:

  • Added logic to adjust position of the floating menu on right overflow, if there is space available on the viewport.
Screencast.from.11-05-24.08.28.21.AM.IST.webm

Copy link

cla-bot bot commented May 11, 2024

We require contributors to sign our Contributor License Agreement, and we don"t have one on file for you. In order for us to review and merge your code, please contact our team at https://www.quadratichq.com/contact.

Copy link

vercel bot commented May 11, 2024

@AyushAgrawal-A2 is attempting to deploy a commit to the Quadratic Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

cla-bot bot commented May 11, 2024

We require contributors to sign our Contributor License Agreement, and we don"t have one on file for you. In order for us to review and merge your code, please contact our team at https://www.quadratichq.com/contact.

Copy link

cla-bot bot commented May 11, 2024

We require contributors to sign our Contributor License Agreement, and we don"t have one on file for you. In order for us to review and merge your code, please contact our team at https://www.quadratichq.com/contact.

@davidfig davidfig mentioned this pull request May 11, 2024
2 tasks
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/1343 branch May 11, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: FloatingContextMenu overflows the viewport on the right side
1 participant