Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messaging, documentation, testing, code org #1341

Merged
merged 17 commits into from May 21, 2024

Conversation

ddimaria
Copy link
Collaborator

  • Better errors, show errors in the editor console, add response metrics, display metrics in std_out

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ❌ Failed (Inspect) May 21, 2024 9:24pm

@cla-bot cla-bot bot added the cla-signed label May 10, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1341 May 10, 2024 21:42 Inactive
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 30.71429% with 291 lines in your changes are missing coverage. Please review.

Project coverage is 87.95%. Comparing base (5d76b6b) to head (95ab9a8).
Report is 5 commits behind head on next-connections.

Files Patch % Lines
quadratic-rust-shared/src/sql/mysql_connection.rs 0.00% 115 Missing ⚠️
...adratic-rust-shared/src/sql/postgres_connection.rs 0.00% 92 Missing ⚠️
quadratic-rust-shared/src/sql/mod.rs 0.00% 64 Missing ⚠️
quadratic-core/src/values/arrow.rs 67.56% 12 Missing ⚠️
quadratic-rust-shared/src/error.rs 0.00% 7 Missing ⚠️
quadratic-rust-shared/src/quadratic_api.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           next-connections    #1341      +/-   ##
====================================================
- Coverage             88.33%   87.95%   -0.38%     
====================================================
  Files                   163      164       +1     
  Lines                 26472    26779     +307     
====================================================
+ Hits                  23384    23554     +170     
- Misses                 3088     3225     +137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1341 May 13, 2024 23:12 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1341 May 14, 2024 16:22 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1341 May 14, 2024 23:12 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1341 May 15, 2024 23:40 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1341 May 16, 2024 22:02 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1341 May 17, 2024 22:41 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1341 May 20, 2024 23:37 Inactive
@ddimaria ddimaria marked this pull request as ready for review May 21, 2024 21:01
@ddimaria ddimaria merged commit 5c11ca9 into next-connections May 21, 2024
5 of 8 checks passed
@ddimaria ddimaria deleted the better-connection-errors branch May 21, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants