New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code editor paneling #1334
Code editor paneling #1334
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1334 +/- ##
=======================================
Coverage 90.06% 90.06%
=======================================
Files 134 134
Lines 24288 24288
=======================================
Hits 21876 21876
Misses 2412 2412 ☔ View full report in Codecov by Sentry. |
…ing multiplayer mousemove)
When you try to resize beyond the maximum bounds, there's still like a ~100px it's still resizing on the right (even though it's not on the left) Happens when the console/AI assistant is expanded out CleanShot.2024-05-06.at.10.40.14.mp4As well as when it's collapsed. CleanShot.2024-05-06.at.10.42.20.mp4 |
A similar thing happens when you resize below the minimum size and you can end up in a position where it starts resizing before you hit the resize threshold. CleanShot.2024-05-06.at.10.54.05.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW: I started thinking about this in the context of how we'd do it so this works on mobile but probably not worth biting off yet.
That said, there are a few problems when you're resizing larger or smaller than the min/max sizes.
Changes layout so
<CodeEditor />
is a flex sibling of the pixi canvas, instead of positioned over it.