Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code editor paneling #1334

Merged
merged 19 commits into from May 14, 2024
Merged

Code editor paneling #1334

merged 19 commits into from May 14, 2024

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented May 6, 2024

Changes layout so <CodeEditor /> is a flex sibling of the pixi canvas, instead of positioned over it.

@cla-bot cla-bot bot added the cla-signed label May 6, 2024
Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview May 14, 2024 3:59pm

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1334 May 6, 2024 14:16 Inactive
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (79c0a62) to head (466b6b0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1334   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files         134      134           
  Lines       24288    24288           
=======================================
  Hits        21876    21876           
  Misses       2412     2412           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1334 May 6, 2024 15:35 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1334 May 6, 2024 15:37 Inactive
@jimniels
Copy link
Collaborator

jimniels commented May 6, 2024

When you try to resize beyond the maximum bounds, there's still like a ~100px it's still resizing on the right (even though it's not on the left)

Happens when the console/AI assistant is expanded out

CleanShot.2024-05-06.at.10.40.14.mp4

As well as when it's collapsed.

CleanShot.2024-05-06.at.10.42.20.mp4

@jimniels
Copy link
Collaborator

jimniels commented May 6, 2024

A similar thing happens when you resize below the minimum size and you can end up in a position where it starts resizing before you hit the resize threshold.

CleanShot.2024-05-06.at.10.54.05.mp4

Copy link
Collaborator

@jimniels jimniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW: I started thinking about this in the context of how we'd do it so this works on mobile but probably not worth biting off yet.

That said, there are a few problems when you're resizing larger or smaller than the min/max sizes.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1334 May 6, 2024 17:52 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1334 May 14, 2024 15:47 Inactive
@davidkircos davidkircos merged commit 0cb59a1 into main May 14, 2024
12 of 13 checks passed
@davidkircos davidkircos deleted the code-editor-paneling branch May 14, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application layout (paneling) canvas, code editor
3 participants