Updates to Extensions #4750
Updates to Extensions #4750
Conversation
in the top level config maybe? |
| @@ -58,54 +59,80 @@ def node_args(self, enabled=True, highlight=False, relative_url=str()): | |||
| } | |||
|
|
|||
|
|
|||
| def calc_vertex_position(number_nodes, include_origin=True, radius=2, offset=0, rounding=2): | |||
| """ | |||
| Generator to calculate x, y coordinates for vertices on a regular polygon. | |||
There was a problem hiding this comment.
can you make this comment regular inscribed polygon? i had to stare at your math for a while to understand what was happening.
| @@ -100,7 +110,7 @@ class RunCommand(_Extension): | |||
| # among all the objects inheriting this class, and if one of them | |||
| # modified it, all the other objects would see the modified list; | |||
| # use a string or a tuple instead, which are immutable | |||
| ("command", None, "the command to be launched (string or list with arguments)"), | |||
| ("cmd", None, "the command to be launched (string or list with arguments)"), | |||
There was a problem hiding this comment.
is there a motivation for this change?
There was a problem hiding this comment.
Yes. CommandObject has a command method so this clashes with that.
| @@ -62,24 +62,29 @@ class CommandSet(Dmenu): | |||
| """ | |||
|
|
|||
| defaults = [ | |||
| ("commands", None, "dictionary of commands where key is runable command"), | |||
| ("commandset", None, "dictionary of commands where key is runable command"), | |||
There was a problem hiding this comment.
commanddict? but can we just leave this as commands, or is there a technical reason not to?
There was a problem hiding this comment.
As above, CommandObject also has a commands method.
There was a problem hiding this comment.
Oof, ok, that's unfortunate. (But still, isn't this a dict?)
There was a problem hiding this comment.
Yes - it's an annoying clash.
And, yes, it's a dict. Will fix.
elParaguayo
force-pushed
the
extension-command-object
branch
from
f3f515b
to
44c3a9d
Compare
Draft for now.
This PR makes a few changes to extensions:
CommandObjects i.e. they can be accessed via qtile's command graph so we can dolazy.extension["extensionname"].run()Outstanding: