Bind keys with keycodes #4707
Draft
Bind keys with keycodes #4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 90 days with no activity. Remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for now...
Based on the discussion in #933 this is an attempt to allow users to bind keys via keycode rather than keysym.
Keycodes can be bound with:
Where
key_codeis an integer value (compared to keysyms being strings).Ideally, I need users to test this and report any bugs.
@jwijenbergh @m-col would welcome thoughts on the wayland implementation. I've hardcoded this to match against
self.keyboards[0]but not sure if that's appropriate or not.CI will almost certainly fail for the time being too!