Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] docs(setup): Documentation #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tonivj5
Copy link
Collaborator

@tonivj5 tonivj5 commented Jul 19, 2017

Hi! Here are the docs 馃槈



- It can be deployed to github-pages

- It is in english and spanish language

- We use hugo to create the docs

- We use a fork of vjeantet/hugo-theme-docdock as theme (our theme adds multilingual features and plunker shortcode to add live examples)

- Added gulp and package.json scripts to work with the documentation (build/clean/deploy)



You can have a glance at https://xxxtonixxx.github.io/ngx-inline-editor/en/ and plunker example at https://xxxtonixxx.github.io/ngx-inline-editor/en/usage/first-example/

- It can be deployed to github-pages
- It is in english and spanish language
- We use hugo to create the docs
- We use a fork of `vjeantet/hugo-theme-docdock` as theme (our theme add multilangual features)
- Added gulp and package.json scripts to work with documentation (build/clean/deploy)
@rifansi
Copy link

rifansi commented Aug 25, 2017

Hi @xxxTonixxx
The updated doc looks very good.
However I didnt get it working there
https://xxxtonixxx.github.io/ngx-inline-editor/en/usage/first-example/

I have tried also in mine. code is not working for type "text" and "textarea"

Please suggest

@tonivj5
Copy link
Collaborator Author

tonivj5 commented Aug 25, 2017

Thanks @rifansi! Yeah, it seems broken since 0.2.0-alpha.10. I think that reactive-forms or change to OnPush strategy have broken the component. I will work to resolve it.

To play with the example, you can set the version to 0.2.0-alpha.9 changing the config.js file in /, into map object, change

'@qontu/ngx-inline-editor': 'https://npmcdn.com/@qontu/ngx-inline-editor',

to

// Version 0.2.0-alpha.9
'@qontu/ngx-inline-editor': 'https://npmcdn.com/@qontu/ngx-inline-editor@0.2.0-alpha.9', 

Here is working with the change done: https://embed.plnkr.co/GfGHaUdbPWyg7xBmN4vg/

@rifansi
Copy link

rifansi commented Aug 28, 2017

Thanks @xxxTonixxx
it's working perfectly at 0.2.0-alpha.9

@tonivj5
Copy link
Collaborator Author

tonivj5 commented Sep 11, 2017

@rifansi the error was fixed in the latest version: 0.2.0-alpha.11. Thanks for your report 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants