Add via support for craftwalk #23658
Conversation
github-actions
bot
added
keyboard
keymap
via
There was a problem hiding this comment.
According to the PR checklist:
keyboard updates and refactors (eg. to data driven) must go through
developto reducemaster->developmerge conflicts
There have been significant changes on the develop branch so you may need to resolve conflicts after switching.
keyboards/craftwalk/info.json
Outdated
| @@ -4,10 +4,13 @@ | |||
| "url": "https://github.com/sotoba/craftwalk", | |||
| "maintainer": "sotoba", | |||
| "usb": { | |||
| "vid": "0xFEED", | |||
| "vid": "0x0E44", | |||
There was a problem hiding this comment.
Someone already owns this vendor ID: https://the-sz.com/products/usbid/index.php?v=0x0E44
If you don't have permission from them to use it, pick a different one (over 0x4000). You may want to use yanfali's checker to verify no overlap.
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
|
switched the target branch and resolved the conflicts. |
|
I apologize for requesting a review before all the points have been addressed. I have addressed all the points you have pointed out, so could you please check it? |
Description
Add via support for craftwalk.
Types of Changes
Checklist