Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell.nix: Fix compatibility with Nix >= 2.10.0 on x86_64-darwin #17673

Merged
merged 1 commit into from
Jul 18, 2022

Commits on Jul 13, 2022

  1. Remove Nixpkgs-provided poetry from the environment

    The `poetry` package from the used Nixpkgs snapshot triggers the regex
    compatibility issue in Nix >= 2.10.0 binaries for `x86_64-darwin`:
    
        https://www.github.com/NixOS/nix/issues/4758
    
    Remove the `poetry` package from the Nix shell environment for now
    (it is not really required to compile QMK, only to develop the Nix shell
    environment itself).
    
    In addition, all `poetry` version earlier than 1.1.14 became effectively
    non-functional after a breaking change of the PyPI JSON API:
    
        https://www.github.com/python-poetry/poetry/pull/5973
    
    Updating the `poetry` package is not trivial (just adding it it to
    `pyproject.toml` does not work due to dependency version conflicts with
    other modules), therefore removing it seems to be the easiest solution
    to restore compatibility with new Nix versions while not creating any
    major inconvenience for QMK users.
    sigprof committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    226718e View commit details
    Browse the repository at this point in the history