Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tutorial that focuses on the transpilation steps #30

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ElePT
Copy link
Collaborator

@ElePT ElePT commented Mar 26, 2024

Summary

Details and comments

@ElePT ElePT requested a review from eggerdj as a code owner March 26, 2024 14:49
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ElePT ElePT changed the title [WIP] Add a tutorial that focus on the transpilation steps [WIP] Add a tutorial that focuses on the transpilation steps Mar 26, 2024
@eggerdj
Copy link
Collaborator

eggerdj commented Mar 27, 2024

The NB looks very good. A few suggestions:

  • Add a concluding text to point out the key things we learnt.
  • Explicitly mention that this is transpiled to a line of qubits. Here, you can point out that a line is generally very good for QAOA and that more connectivity, e.g., 2D grid does not help (this point is discussed in Weidenfeller et al.)

Copy link
Collaborator Author

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documenting some external feedback and ideas I plan to implement:

  • check the quality of the layout/routing with a noisy simulation + classical reference
  • add an experiment customizing the default transpiler passes instead of replacing them with manually constructed passes

@ElePT ElePT changed the title [WIP] Add a tutorial that focuses on the transpilation steps Add a tutorial that focuses on the transpilation steps Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants