Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Dynamical decoupling #11

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

eggerdj
Copy link
Collaborator

@eggerdj eggerdj commented Nov 28, 2023

Summary

This PR adds support for dynamical decoupling.

Details and comments

TODO

@eggerdj eggerdj requested a review from ElePT as a code owner November 28, 2023 11:40
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a WIP and the notebook is unfinished, but I added a few minor comments on the content already there in case they help.

how_tos/how_to_add_dynamical_decoupling.ipynb Outdated Show resolved Hide resolved
how_tos/how_to_add_dynamical_decoupling.ipynb Outdated Show resolved Hide resolved
how_tos/how_to_add_dynamical_decoupling.ipynb Outdated Show resolved Hide resolved
how_tos/how_to_add_dynamical_decoupling.ipynb Outdated Show resolved Hide resolved
how_tos/how_to_add_dynamical_decoupling.ipynb Outdated Show resolved Hide resolved
@Durd3nT
Copy link
Contributor

Durd3nT commented Dec 18, 2023

The PadDynamicalDecoupling pass takes away the layout of the circuit. This should be highlighted in the documentation of that class, but also in tutorials such as this one.
One potential issue caused by this is that transpiling observables based on the circuit layout will fail if your workflow looks like below.

t_circ = transpile(circ, ...)
t_circ = dd_passmanager(...).run(t_circ)

t_observable = SparsePauliOp(...).apply_layout(t_circ.layout)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants