Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split POVM and DUAL classes #10

Merged
merged 31 commits into from May 14, 2024
Merged

Split POVM and DUAL classes #10

merged 31 commits into from May 14, 2024

Conversation

timmintam
Copy link
Collaborator

@timmintam timmintam commented Apr 26, 2024 •
edited

Closes #2

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@timmintam timmintam changed the title add frame superclass and start the splitting Split POVM and DUAL classes Apr 26, 2024
mrossinek
mrossinek reviewed May 7, 2024
View reviewed changes
Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments. Otherwise this already looks like its going in a good direction 👍

povm_toolbox/post_processor/povm_post_processor.py Outdated Show resolved Hide resolved
povm_toolbox/post_processor/povm_post_processor.py Outdated Show resolved Hide resolved
povm_toolbox/post_processor/povm_post_processor.py Outdated Show resolved Hide resolved
povm_toolbox/post_processor/povm_post_processor.py Outdated Show resolved Hide resolved
povm_toolbox/quantum_info/base_frame.py Outdated Show resolved Hide resolved
povm_toolbox/quantum_info/base_dual.py Outdated Show resolved Hide resolved
povm_toolbox/quantum_info/multi_qubit_dual.py Outdated Show resolved Hide resolved
povm_toolbox/quantum_info/multi_qubit_dual.py Outdated Show resolved Hide resolved
povm_toolbox/quantum_info/old/base_povm.py Outdated Show resolved Hide resolved
@timmintam timmintam marked this pull request as ready for review May 13, 2024 14:54
@timmintam timmintam requested a review from mrossinek May 13, 2024 14:55
@timmintam
Copy link
Collaborator Author

Hey @mrossinek , I think this PR is in good enough shape to be merged now.

There are some points to improve, for instance how the DUAL classes and the POVMPostProcessor currently interact is not super clean. Also how the user can 'optimize' the dual frame as part of the post-processing could be cleaner...

But I think it is good enough for this PR, especially as the main goals of this PR (namely splitting POVM and DUAL classes) are achieved imo. We can tackle the points mentioned above in a follow-up PR (otherwise this one will get really too big).

mrossinek
mrossinek reviewed May 13, 2024
View reviewed changes
Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some final documentation details, but other than that this LGTM 👍

povm_toolbox/post_processor/povm_post_processor.py Show resolved Hide resolved
povm_toolbox/post_processor/povm_post_processor.py Outdated Show resolved Hide resolved
povm_toolbox/post_processor/povm_post_processor.py Outdated Show resolved Hide resolved
povm_toolbox/quantum_info/base_dual.py Outdated Show resolved Hide resolved
povm_toolbox/quantum_info/base_dual.py Outdated Show resolved Hide resolved
povm_toolbox/quantum_info/base_frame.py Show resolved Hide resolved
povm_toolbox/quantum_info/base_povm.py Outdated Show resolved Hide resolved
povm_toolbox/quantum_info/base_povm.py Show resolved Hide resolved
@timmintam timmintam requested a review from mrossinek May 14, 2024 11:41
mrossinek
mrossinek approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timmintam timmintam merged commit c9a34fe into main May 14, 2024
8 checks passed
@timmintam timmintam deleted the split_dual_from_povm branch May 14, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrossinek mrossinek mrossinek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split POVM and DUAL classes.
3 participants
@timmintam @CLAassistant @mrossinek