-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QulacsBackend
#1272
base: master
Are you sure you want to change the base?
QulacsBackend
#1272
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1272 +/- ##
==========================================
+ Coverage 99.82% 99.85% +0.03%
==========================================
Files 72 74 +2
Lines 10560 10673 +113
==========================================
+ Hits 10541 10658 +117
+ Misses 19 15 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@scarrazza some preliminary results for the qulacs backend, it looks indeed comparable with our `qibojit 1 core8 cores |
Thanks @BrunoLiegiBastonLiegi, could you please include some GPU curves too? |
Yes I am trying to install the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, however we are missing documentation.
I added a small paragraph in the documentation about |
I just opened a PR in the Xmind-diagrams repo adding Qulacs to diagrams. |
Apparently there is some problem with Edit: I was able to reproduce the problem locally, it looks like with |
This adds
qulacs
as an optional backend.Checklist: