Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Parallel batch execution for VQC #1186

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

BrunoLiegiBastonLiegi
Copy link
Contributor

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi commented Feb 2, 2024

This implements the parallel execution of batches of different initial states for the same initial circuit. This is particularly helpful for amplitude encoding based VQCs @Edoardo-Pedicillo.

What is supported:

  • getting the batch of final states
  • getting the batch of final samples
  • getting the batch of final probabilities

What is not (yet) supported or tested:

  • getting the final frequencies
  • density_matrix=True simulations
  • noisy simulation and collapsing measurements

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi changed the base branch from master to clifford_channels February 2, 2024 13:46
Base automatically changed from clifford_channels to master February 3, 2024 04:16
@renatomello renatomello self-requested a review February 7, 2024 12:20
@renatomello renatomello added the enhancement New feature or request label Feb 7, 2024
@renatomello renatomello added this to the Qibo 0.2.6 milestone Feb 7, 2024
@renatomello renatomello added the documentation Improvements or additions to documentation label Feb 7, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (45e4e22) 99.96% compared to head (fcf4747) 99.90%.

Files Patch % Lines
src/qibo/backends/einsum_utils.py 76.92% 3 Missing ⚠️
src/qibo/backends/numpy.py 94.73% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1186      +/-   ##
==========================================
- Coverage   99.96%   99.90%   -0.06%     
==========================================
  Files          70       70              
  Lines       10414    10438      +24     
==========================================
+ Hits        10410    10428      +18     
- Misses          4       10       +6     
Flag Coverage Δ
unittests 99.90% <93.15%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scarrazza scarrazza modified the milestones: Qibo 0.2.6, Qibo 0.2.7 Mar 13, 2024
@scarrazza scarrazza modified the milestones: Qibo 0.2.7, Qibo 0.2.8 Apr 5, 2024
@scarrazza scarrazza modified the milestones: Qibo 0.2.8, Qibo 0.2.9 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants