New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ColorWidget] Add CMYK support #57361
Conversation
@troopa81 There's a fair amount of wasted space in the dialog caused by putting the combo box in the top left corner. Could we try moving it here instead? How does this look in the vertical orientation mode used in the styling dock color buttons too? Can you share a screenshot showing that? |
Question: is the use of rounded integer 0-255 values an issue when using CMYK colors? It's been on my wishlist for a while to revisit these widgets and make them return qreal values for the color components, so that we aren't losing information when a color is changed via the widget and are better equipped to handle higher precision color models in future (since these are already supported by both Qt and our color reading/writing code, it's really only the color widget itself holding us back). |
As much as RGB color I think. Do you have a specific issue in mind ? or just the lack of precision when you use the color wheel widget for instance |
66b738f
to
8e8179a
Compare
Way better indeed. Done and updated video accordingly |
One reason to use CMYK is so that you can hit very specific spot colours used by your printers. This allows prints to get very high DPI at the tones you specify, because they don't need to use screens to dither various colours together. If I can't specify the exact percentages from my printer's catalogue of spot colours, and have them propagate all the way through to a CMYK-colourspace PDF put out by the Layout Manager, then the result will be a very expensive print of a map with degraded quality. |
@nyalldawson I remoed the warning message @spacehobo Good point, I'll try to deal with this in another PR if I have the time/budget. |
A new setting activeCmykComponent has been introduced, while the old one activeComponent refers now only to the Rgb/Hsv part
8aceb92
to
bb97a02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one little change left
This is the first PR regarding CMYK QEP
It adds CMYK support in color widget so we can select CMYK color.
A new setting activeCmykComponent has been introduced, while the old one activeComponent refers now only to the Rgb/Hsv part
Funded by Métropôle de Bordeaux