Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qgs3dmapconfigwidget: Only display shadow debug map if shadows are enabled #57337

Closed
wants to merge 1 commit into from
Closed

qgs3dmapconfigwidget: Only display shadow debug map if shadows are enabled #57337

wants to merge 1 commit into from
+3 −1

Conversation

ptitjano
Copy link
Contributor

@ptitjano ptitjano commented May 3, 2024

Description

The shadow debug map can be enabled from the configuration widget even if no shadow effect is enabled. In that case, the shadow map does not make it any sense.

This issue is fixed by displaying the shadow debug map only if at least one shadow effect is enabled.

@github-actions github-actions bot added this to the 3.38.0 milestone May 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024 •
edited

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 762835e)

@ptitjano
qgs3dmapconfigwidget: Only display shadow debug map if shadows are en…
762835e 
…abled

The shadow debug map can be enabled from the configuration widget even
if the shadow effect is not enabled. In that case, the displayed
shadow map does not make it any sense.

This issue is fixed by displaying the shadow debug map only if the
shadow effect is enabled.
@nyalldawson
Copy link
Collaborator

I'd be in favour of hiding this option from the gui entirely.

Or even better, we could move ALL the debug/developer related 3d settings to their own page in the developer tools dock...

@github-actions GitHub Actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label May 18, 2024
@github-actions GitHub Actions
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Milestone
3.38.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ptitjano @nyalldawson