Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert custom formatting for guilabel and menuselection #8784

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DelazJ
Copy link
Collaborator

@DelazJ DelazJ commented Jan 15, 2024

Afair :menuselection: didn't have a special formatting in readthedocs theme so we made these changes to have both look alike, as in our pre-readthedocs theme time. They both look alike now in the theme (readthedocs/sphinx_rtd_theme#1426) so let's remove our customization. Opinions?

BEFORE
image

AFTER
image

Afair :menuselection: didn't have a special formatting in readthedocs theme so we made these changes to have both look alike, as in our pre-readthedocs theme time. They both look alike now in the theme so let's remove our customization
@DelazJ DelazJ added Backend backport release_3.34 On merge create a backported pull request to 3.34 labels Jan 15, 2024
@selmaVH1
Copy link
Collaborator

Hello @DelazJ, I've received several warnings while trying to generate an HTML preview. These warnings are not linked to the files I am currently modifying. Are the warnings and failed checks in the pull request related to changes in this PR?
Code_WgEU3OQj2E

@DelazJ
Copy link
Collaborator Author

DelazJ commented Jan 19, 2024

Not at all. This is a PR so has zero influence on anything other than its own branch.
Delete the build/html folder in your local repository and you should be good with the last block of warnings. For the first, it's weird you get that because the changes have been merged some time ago already, and it should probably be fixed with the previous deletion tip also. For the warning in the middle it's related to the changes you are locally doing.

@selmaVH1
Copy link
Collaborator

Not at all. This is a PR so has zero influence on anything other than its own branch. Delete the build/html folder in your local repository and you should be good with the last block of warnings. For the first, it's weird you get that because the changes have been merged some time ago already, and it should probably be fixed with the previous deletion tip also. For the warning in the middle it's related to the changes you are locally doing.

Understood, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend backport release_3.34 On merge create a backported pull request to 3.34
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants