Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the path for forbidden dir in child folder #387

Merged
merged 3 commits into from
May 22, 2024

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Apr 22, 2024

This is a proposed fix for #312

If the forbidden dir is in the root folder:

image

If the forbidden dir is inside a child folder:

image

Copy link

@lnicola lnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd rephrase the message perhaps ("For security reasons, the ZIP file cannot contain a %s directory.", "However, there is one present at the root of the archive.") but it's clear enough already.

@Xpirix
Copy link
Collaborator Author

Xpirix commented Apr 23, 2024

Thanks for the review. I think your suggestion is more precise, I've made the change.

@dimasciput dimasciput merged commit f22c66e into qgis:master May 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants