Set media and static path as the same as in production #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #357 +/- ##
=======================================
Coverage 36.06% 36.06%
=======================================
Files 111 111
Lines 4899 4899
=======================================
Hits 1767 1767
Misses 3132 3132 ☔ View full report in Codecov by Sentry. |
dimasciput
reviewed
Feb 20, 2024
qgis-app/settings_docker.py
Outdated
|
|
||
| # URL prefix for static files. | ||
| # Example: "http://example.com/static/", "http://static.example.com/" | ||
| STATIC_URL = "/static/" | ||
| STATIC_URL = "/static/static/" |
There was a problem hiding this comment.
perhaps also use environment variable here, and make '/static/' as default
There was a problem hiding this comment.
Thanks for the review @dimasciput , I've made the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to set the path for the media and static folder as the same as in production since we split these two.