removed some contradictory code #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in common/main.c, the cread_print_hist_list function is defined inside a #ifndef CONFIG_CMDLINE_EDITING defination. However, this code snippest is inside a bigger #ifdef CONFIG_CMDLINE_EDITING which begin its defination at line and ends it defination at line 916. So the function presence condition will never be met.
in net/bootp.c, the situation is similar, the code code snippest I have deleted precense condition will never be met due to the #ifndef CONFIG_CMD_DHCP(line 356 and 'else' in line 470) and the block itself presence condition #ifdef CONFIG_CMD_DHCP.