Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily pack json-with-bigint locally until this package supports CJS modules #9

Merged
merged 2 commits into from Feb 20, 2024

Conversation

Rendez
Copy link
Collaborator

@Rendez Rendez commented Feb 20, 2024

json-with-bigint does not support CJS, and this led to issues for users of the our JS SDK loading CJS in Node:

https://discord.com/channels/907569970500743200/1209507491746942976/1209507491746942976

We'll add support for ESM ourselves. In the meantime, this packs the dependency locally, since rolling back also introduces regressions in the GH workflows and vulnerability issues that got resolved when we merged the PR previously.

@Rendez Rendez added the bug Something isn't working label Feb 20, 2024
Copy link
Member

@kartik-gupta-ij kartik-gupta-ij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed this.

@Rendez Rendez merged commit 15124d1 into main Feb 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants