Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix-Constants must be aligned #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bugfix-Constants must be aligned #23

wants to merge 1 commit into from

Conversation

kukrik
Copy link
Member

@kukrik kukrik commented Aug 22, 2020

Constants must be aligned with /application/src/Action/ActionParams.php

Please see there /application/src/Action/ActionParams.php lines 33 - 42!

…arams.php

Please see there /application/src/Action/ActionParams.php lines 33 - 42!
@kukrik
Copy link
Member Author

kukrik commented Aug 22, 2020

If these constants are not corrected, then
one example

$this->strActiveItemId = $params->{ControlBase::ACTION_PARAM};

or
second example

$this->strSelectedItemId = $params->{ControlBase::ACTION_PARAM};

didn't work properly ...

And these examples didn't work in the @spekary Bootstrap Nav and ListGroup class unless corrected these constants in the Controlbase class.

This means that if a similar solution is needed in other developments, they would definitely not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant